Skip to content

Resurrect tracking performance scripts#43

Open
Victor-Schwan wants to merge 8 commits intoiLCSoft:masterfrom
Victor-Schwan:resurrect
Open

Resurrect tracking performance scripts#43
Victor-Schwan wants to merge 8 commits intoiLCSoft:masterfrom
Victor-Schwan:resurrect

Conversation

@Victor-Schwan
Copy link
Copy Markdown

BEGINRELEASENOTES

  • Update to RHEL 9 and ILCSOFT v02-03-04
  • Put final plots also in Results folder and not somewhere in the home dir
  • Translate READMEs to Markdown
  • Format Python script

ENDRELEASENOTES

Copy link
Copy Markdown
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ILDPerformance built as part of a regular Key4hep stack by any chance?

Comment on lines +8 to +10
ILCSOFTVER=v02-03-04

. /afs/desy.de/project/ilcsoft/sw/x86_64_gcc49_sl6/${ILCSOFTVER}/init_ilcsoft.sh
. /afs/desy.de/project/ilcsoft/sw/x86_64_gcc131_el9/${ILCSOFTVER}/init_ilcsoft.sh
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you would do this on Key4hep in the end? Does that also work? From a quick look, it seems like ILCSOFTVER is used for creating some output directories as well(?)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is intended to be the minimal change to get the code to run (+formatting). It did work in key4hep as well, but I suggest to put this in another PR

@Victor-Schwan
Copy link
Copy Markdown
Author

Is ILDPerformance built as part of a regular Key4hep stack by any chance?

I do not know

@tmadlener
Copy link
Copy Markdown
Contributor

Anything still missing from this one? If not, I would merge.

@Victor-Schwan
Copy link
Copy Markdown
Author

Should be complete. Feel free to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants