fix(lark): don't replay pre-authorization messages as chats#603
Open
loind wants to merge 1 commit into
Open
Conversation
A message sent before a user is authorized only serves to hand out a
pairing code; it must never be dispatched to the agent. If the platform
redelivers that message (e.g. after a reconnect), it was being replayed
as a real chat message and the bot auto-replied ("hi" → "Hello!").
Drop messages whose timestamp predates the user's authorized_at, and add
a MessageResult::Ignored no-op variant for that path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A message a user sends before being authorized only serves to hand out a pairing code — it must never be dispatched to the agent. If the platform redelivers that message (e.g. after a WebSocket reconnect), it was being replayed as a real chat message and the bot auto-replied (observed: a
"hi"used to pair produced an unsolicited"Hello!"on Lark after approval).Fix
handle_incoming_message: drop messages whosetimestamppredates the user'sauthorized_at(unix seconds vs millis). Pairing-era / redelivered messages no longer become chats; genuinely new messages (sent after approval) are unaffected.MessageResult::Ignoredno-op variant for that path (handled inorchestrator.rs).PairingService::get_authorized_userreturns(id, authorized_at)in one lookup.Testing
action::tests::message_before_authorization_is_ignored.cargo test -p aionui-channel— all green.Notes
Platform-agnostic (applies to all channels). Independent of the Lark region work (#602).