updated * to itwinui 3 by nimam-bentley · Pull Request #141 · iTwin/admin-components-react

nimam-bentley · 2025-01-16T17:29:53Z

update itwinui versions in imodel-browser to latest 3.x
upgraded legacy props to components, including adding Tile.Action area
improves accessibility

UPDATE

updated all remaining packages to latest itwinui 3.x
^ this broke a bunch of tests, most of the changes in this pr are now for fixing them
^ part of this is updating @testing-library and adjusting some of the methods/locators

Note

would make some suggestions, pending state at merge, separate issues can be created

migrate from .iui- classes to itwinui components
use preferable locators [partially done in this pr]
shift test assertions of implementation details to user expectations, ensuring accessibility

aruniverse · 2025-01-16T18:04:43Z

-    "@itwin/itwinui-icons-react": "^2.2.0",
-    "@itwin/itwinui-react": "^2.12.18",
+    "@itwin/itwinui-icons-react": "^2.9.0",
+    "@itwin/itwinui-react": "^3.16.5",


i think itiwnui would need to become a peer dep

updated all packages in monorepo

i dont see this as a dev+peer dep

should also use the latest version, 3.17, to add support for the theme bridge

i dont see this as a dev+peer dep

its used in prod implementation in this package. i could add it as a peer but i dont think anything else here would have the same subdep on itwinui-react? why in dev if needed in prod?

should also use the latest version, 3.17, to add support for the theme bridge

updated to latest 3.17.3

DanishMehmood-bit · 2025-03-16T07:17:12Z

Can we bump the priority on this one, since iTwin for Desktop wants to upgrade to itwinui's theme bridge and according to their wiki all of the dependencies should be on v3 and we depend on imodel-browser-react pkg

@aruniverse @nimam-bentley @kckst8

aruniverse

plz review existing comments?
is there a need to update every single pkg in this monorepo for your app?

aruniverse · 2025-01-29T18:49:31Z

-    "@itwin/itwinui-icons-react": "^2.2.0",
-    "@itwin/itwinui-react": "^2.12.18",
+    "@itwin/itwinui-icons-react": "^2.9.0",
+    "@itwin/itwinui-react": "^3.16.5",


i dont see this as a dev+peer dep

aruniverse · 2025-01-29T18:51:01Z

    "tslib": "^2.6.2",
-    "typescript": "^4.2.3"
+    "typescript": "^4.2.3",
+    "@testing-library/dom": "~10.4.0",


lets alphabetize our deps

lets alphabetize our deps

moved the '@' prefixed deps

aruniverse · 2025-01-29T19:23:45Z

@@ -13,7 +13,7 @@
    "@itwin/delete-imodel-react": "^2.0.0",
    "@itwin/delete-itwin-react": "^2.0.0",
    "@itwin/imodel-browser-react": "~2.3.1",


shouldnt these (pkgs within the monorepo) be using the workspace:* protocol?

shouldnt these (pkgs within the monorepo) be using the workspace:* protocol?

that would make sense, however workspace does not appear to be configured in this repo perhaps that change should be in its own pr

aruniverse · 2025-03-17T02:36:55Z

-    "@itwin/itwinui-icons-react": "^2.2.0",
-    "@itwin/itwinui-react": "^2.12.18",
+    "@itwin/itwinui-icons-react": "^2.9.0",
+    "@itwin/itwinui-react": "^3.16.5",


should also use the latest version, 3.17, to add support for the theme bridge

aruniverse · 2025-03-17T02:44:29Z

@@ -11,28 +11,24 @@ import React, { forwardRef } from "react";
 export const IModelGhostTile = forwardRef<HTMLDivElement>((props, ref) => {
  return (
    <ThemeProvider ref={ref} theme="inherit" {...props}>


if the plan is to use the theme bridge, then wouldnt you need to expose that for every single component that you wrap with theme provider?

would it make more sense to not wrap anything in theme provider, and expect the host/parent app to do so instead?

if the plan is to use the theme bridge, then wouldnt you need to expose that for every single component that you wrap with theme provider?

would it make more sense to not wrap anything in theme provider, and expect the host/parent app to do so instead?

i think it would be fine given the theme is set to inherit?
https://itwinui.bentley.com/docs/themeprovider#inheritance

nimam-bentley · 2025-03-20T15:26:07Z

plz review existing comments? is there a need to update every single pkg in this monorepo for your app?

i only needed imodel-browser updated. its been some time but i recall having some issues updating only that package, and figured they would all need to be updated eventually anyway so might aswell. i think updating the whole repo is also the goal of work item

aruniverse · 2025-04-01T16:40:17Z

closing in favor of #144

mayank99 · 2025-04-01T18:50:58Z

closing in favor of #144

@aruniverse #144 is only concerned with updating @itwin/imodel-browser-react. What about all other packages in this monorepo? Are we abandoning those packages?

aruniverse · 2025-04-01T19:07:29Z

closing in favor of #144

@aruniverse #144 is only concerned with updating @itwin/imodel-browser-react. What about all other packages in this monorepo? Are we abandoning those packages?

I wouldn't say abandon, but if we have no consumers asking for iTwinUI v3 versions of it, then we can defer it

simihartstein · 2025-04-01T19:36:43Z

OpenSite+ is not using any of the other packages in this repo

nimam-bentley added 2 commits January 16, 2025 12:25

updated to itwinui 3 and upgraded tiles from legacy props

73d8f25

changelog

4036a55

nimam-bentley self-assigned this Jan 16, 2025

nimam-bentley requested a review from aruniverse as a code owner January 16, 2025 17:29

aruniverse reviewed Jan 16, 2025

View reviewed changes

raplemie reviewed Jan 16, 2025

View reviewed changes

Comment thread packages/modules/imodel-browser/src/containers/ITwinGrid/ITwinTile.tsx Outdated

nimam-bentley added 2 commits January 19, 2025 19:45

update rest of modules to itwin-ui 3.x, and get all tests passing

563f7fd

exhaustive dep warning

f4b53dc

nimam-bentley requested review from veekeys and williamkbentley as code owners January 20, 2025 00:59

nimam-bentley added 8 commits January 19, 2025 20:04

changelogs

a40ceab

wrap userevents in act

db5e7a7

wrap userevents in act

64a4b1c

cleanup

3202c29

cleanup

0b228ca

cleanup

2046e4b

mismatch resolve

dade065

fix

c72c000

nimam-bentley requested review from aruniverse and raplemie January 24, 2025 01:47

hopefully fix ci timeout

283a12f

nimam-bentley changed the title ~~updated imodel-browser to itwinui 3~~ updated * to itwinui 3 Jan 24, 2025

aruniverse mentioned this pull request Jan 29, 2025

Update to itwin3 #142

Closed

nimam-bentley requested a review from simihartstein February 10, 2025 14:20

simihartstein requested a review from elvisdandrea-bentley February 10, 2025 14:29

Merge branch 'main' into nm/update-imodelbrowser-to-itwinui3

8e4689b

aruniverse reviewed Mar 17, 2025

View reviewed changes

nimam-bentley added 2 commits March 20, 2025 10:34

update rest of modules to itwin-ui 3.x, and get all tests passing

7cc6eef

update latest itwinui

6161734

nimam-bentley added 2 commits March 20, 2025 10:39

alphabetize

718d7f2

alphabetize

6822702

nimam-bentley requested a review from aruniverse March 20, 2025 15:26

aruniverse mentioned this pull request Mar 21, 2025

Updated imodel-browser-react to itwinui-react 3.x #144

Merged

added overrides

141fee0

aruniverse closed this Apr 1, 2025

Conversation

nimam-bentley commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

UPDATE

Note

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DanishMehmood-bit commented Mar 16, 2025 • edited by aruniverse Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aruniverse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nimam-bentley commented Mar 20, 2025

Uh oh!

aruniverse commented Apr 1, 2025

Uh oh!

mayank99 commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aruniverse commented Apr 1, 2025

Uh oh!

simihartstein commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nimam-bentley commented Jan 16, 2025 •

edited

Loading

DanishMehmood-bit commented Mar 16, 2025 •

edited by aruniverse

Loading

mayank99 commented Apr 1, 2025 •

edited

Loading