Skip to content

[minor] Add Public ELB Fetching and AWS Secret Creation to gitops-mas-initiator#2187

Open
Drashti-Malviya wants to merge 9 commits intomasterfrom
fvt-dns
Open

[minor] Add Public ELB Fetching and AWS Secret Creation to gitops-mas-initiator#2187
Drashti-Malviya wants to merge 9 commits intomasterfrom
fvt-dns

Conversation

@Drashti-Malviya
Copy link
Copy Markdown
Contributor

Related Issues
https://jsw.ibm.com/browse/MASCORE-12900

Description
This PR adds functionality to fetch the public Network Load Balancer (NLB) DNS from AWS and store it in AWS Secrets Manager.

@Drashti-Malviya Drashti-Malviya requested a review from a team as a code owner April 16, 2026 05:40
@whitfiea whitfiea changed the title Add Public ELB Fetching and AWS Secret Creation to gitops-mas-initiator [minor] Add Public ELB Fetching and AWS Secret Creation to gitops-mas-initiator Apr 16, 2026
echo "Fetching Network Load Balancer DNS name for fvtsaas VPC..."

# Get VPC ID for fvtsaas
VPC_ID=$(aws ec2 describe-vpcs --filters "Name=tag:Name,Values=*fvtsaas*" --query 'Vpcs[0].VpcId' --output text)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we get the vpc id like this

vpc_name=$(aws ec2 describe-vpcs --output yaml | grep $CLUSTER_NAME- | yq '.[].Value // ""' | xargs)
if [ -z "$vpc_name" ]; then
# Needed if there is only one cluster in account
vpc_name=$(aws ec2 describe-vpcs --output yaml | grep $CLUSTER_NAME- | yq '.Value // ""' | xargs)
fi
export VPC_ID=$(aws ec2 describe-vpcs --filters '[{"Name": "tag:Name", "Values": ["'$vpc_name'"]}]' --output yaml | yq '.Vpcs[].VpcId' )
as there are issues with similiar named vpcs. We should use CLUSTER_NAME rather than hard code it as it would fail if fvtsaas doesn't exist and we are deployinh to a different cluster

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay used the same approach to get vpc id and remove hardcode value,please check

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Drashti-Malviya can you fix the build issue. Plus this needs to be test in an actual fvtsaas execution

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants