[minor] Add Public ELB Fetching and AWS Secret Creation to gitops-mas-initiator#2187
Open
Drashti-Malviya wants to merge 9 commits intomasterfrom
Open
[minor] Add Public ELB Fetching and AWS Secret Creation to gitops-mas-initiator#2187Drashti-Malviya wants to merge 9 commits intomasterfrom
Drashti-Malviya wants to merge 9 commits intomasterfrom
Conversation
whitfiea
reviewed
Apr 16, 2026
| echo "Fetching Network Load Balancer DNS name for fvtsaas VPC..." | ||
|
|
||
| # Get VPC ID for fvtsaas | ||
| VPC_ID=$(aws ec2 describe-vpcs --filters "Name=tag:Name,Values=*fvtsaas*" --query 'Vpcs[0].VpcId' --output text) |
Member
There was a problem hiding this comment.
Normally we get the vpc id like this
cli/tekton/src/tasks/gitops/gitops-kafka.yml.j2
Lines 74 to 79 in 3aad4a3
Contributor
Author
There was a problem hiding this comment.
okay used the same approach to get vpc id and remove hardcode value,please check
Member
There was a problem hiding this comment.
@Drashti-Malviya can you fix the build issue. Plus this needs to be test in an actual fvtsaas execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
https://jsw.ibm.com/browse/MASCORE-12900
Description
This PR adds functionality to fetch the public Network Load Balancer (NLB) DNS from AWS and store it in AWS Secrets Manager.