[codex] Add transport-aware path policy#67
Open
samuelduchesne wants to merge 1 commit into
Open
Conversation
Contributor
|
Docs preview for this PR is available at: Changed pages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds transport-aware filesystem policy for local stdio versus network transports:
IDFKIT_MCP_UPLOAD_DIR,IDFKIT_MCP_OUTPUT_DIRS,IDFKIT_MCP_SIMULATION_DIR)IDFKIT_MCP_INPUT_DIRSis configuredWhy
The external security review correctly identified that arbitrary server-local file reads/writes are acceptable for local MCP use but risky for hosted or multi-user HTTP deployments. This change makes that distinction explicit in code and docs without blocking the local desktop workflow.
Validation
uv run ruff check .uv run ruff format --check .uv run pyrightuv run pytestgit commit