fix(windows): unpack ffmpeg-static from ASAR and fix runtime path#2
Open
ifeelvoid wants to merge 1 commit into
Open
fix(windows): unpack ffmpeg-static from ASAR and fix runtime path#2ifeelvoid wants to merge 1 commit into
ifeelvoid wants to merge 1 commit into
Conversation
Native binaries can't run from inside an ASAR archive. Added asarUnpack rules for ffmpeg-static and essentia.js in package.json, and updated worker.js to rewrite the ffmpeg path from app.asar to app.asar.unpacked when running inside a packaged Electron app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asarUnpackinpackage.jsonforffmpeg-staticandessentia.jsso native binaries are extracted outside the ASAR archive when packagingworker.jsto rewrite the ffmpeg path fromapp.asar/toapp.asar.unpacked/at runtime when running inside a packaged Electron appWhy
Native binaries (like ffmpeg) can't execute from inside an ASAR archive — they need to live on the real filesystem. Without this fix, the packaged Windows app would fail silently when trying to process audio files.
Test plan
npm run buildinkeyfinder-windows/and verify both portable and setup EXEs are generatedASARpath errors in the Electron console