fix(macOS): dismiss Analysis Log sheet with close button and Escape#3
Open
MemeFormer wants to merge 2 commits into
Open
fix(macOS): dismiss Analysis Log sheet with close button and Escape#3MemeFormer wants to merge 2 commits into
MemeFormer wants to merge 2 commits into
Conversation
AnalysisLogView was the only sheet without a dismiss path; on macOS the log can take focus without window chrome, matching Help/Tag/Cue sheets with an explicit close button and onExitCommand. Made-with: Cursor
ifeelvoid
added a commit
that referenced
this pull request
Apr 7, 2026
- Merge PR #3: add dismiss button + Escape key handler to AnalysisLogView - Bump CFBundleShortVersionString/CFBundleVersion to 1.9 in build-app.sh - Bump VERSION to 1.9 in make-dmg.sh and distribute.sh - Update DMG filename references in CLAUDE.md and README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Analysis Log is shown as a SwiftUI sheet (
EnhancedBatchView→AnalysisLogView). On macOS it can appear as a separate window without standard close chrome, especially alongside a hidden title bar on the main window. Unlike Help, tag editor, and cue sheets, the log had no explicit dismiss path, so users could get stuck with the log focused and no obvious way back to the main UI.Solution
@Environment(\.dismiss)and a header close button (consistent withHelpView)..onExitCommand { dismiss() }so Escape dismisses the sheet.Files
Sources/KeyFinder/Views/AnalysisLogView.swiftTesting
./build-app.sh).