Skip to content

fix(tests): catch ConnectionError in WorkOS callback drain calls (Python 3.12+) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igor-ctrl merged 1 commit into from
May 4, 2026
Merged

fix(tests): catch ConnectionError in WorkOS callback drain calls (Python 3.12+) #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions tests/test_auth/test_workos_callback_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,12 @@ def test_authorization_url_includes_state(fake_workos, isolated_identity_cache):
f"?code=ok&state={state}",
timeout=2,
)
except urllib.error.URLError:
except (urllib.error.URLError, ConnectionError):
# urllib.error.URLError covers DNS / connection-refused; ConnectionError
# (incl. ConnectionResetError) leaks through unwrapped on Python 3.12+
# when the server thread closes the socket while we're still reading
# the response. Either is fine for these drain calls — the test's real
# assertions live elsewhere; this just lets the daemon thread exit.
pass
thread.join(timeout=5)

Expand Down Expand Up @@ -219,7 +224,12 @@ def test_callback_with_wrong_path_is_404(fake_workos, isolated_identity_cache):
urllib.request.urlopen(bad_url, timeout=2)
except urllib.error.HTTPError as http_err:
assert http_err.code == 404
except urllib.error.URLError:
except (urllib.error.URLError, ConnectionError):
# urllib.error.URLError covers DNS / connection-refused; ConnectionError
# (incl. ConnectionResetError) leaks through unwrapped on Python 3.12+
# when the server thread closes the socket while we're still reading
# the response. Either is fine for these drain calls — the test's real
# assertions live elsewhere; this just lets the daemon thread exit.
pass

# The 404 path must not consume the listener — the legitimate callback
Expand All @@ -230,7 +240,12 @@ def test_callback_with_wrong_path_is_404(fake_workos, isolated_identity_cache):
)
try:
urllib.request.urlopen(good_url, timeout=2)
except urllib.error.URLError:
except (urllib.error.URLError, ConnectionError):
# urllib.error.URLError covers DNS / connection-refused; ConnectionError
# (incl. ConnectionResetError) leaks through unwrapped on Python 3.12+
# when the server thread closes the socket while we're still reading
# the response. Either is fine for these drain calls — the test's real
# assertions live elsewhere; this just lets the daemon thread exit.
pass

thread.join(timeout=5)
Expand All @@ -252,7 +267,12 @@ def test_matching_state_is_accepted(fake_workos, isolated_identity_cache):
)
try:
urllib.request.urlopen(url, timeout=2)
except urllib.error.URLError:
except (urllib.error.URLError, ConnectionError):
# urllib.error.URLError covers DNS / connection-refused; ConnectionError
# (incl. ConnectionResetError) leaks through unwrapped on Python 3.12+
# when the server thread closes the socket while we're still reading
# the response. Either is fine for these drain calls — the test's real
# assertions live elsewhere; this just lets the daemon thread exit.
pass

thread.join(timeout=5)
Expand Down
Loading