Add support for custom package name in generated go file#152
Open
andrzejressel wants to merge 3 commits into
Open
Add support for custom package name in generated go file#152andrzejressel wants to merge 3 commits into
andrzejressel wants to merge 3 commits into
Conversation
|
+1, this would unblock our workflow as well |
lirenjie95
reviewed
Mar 28, 2026
Collaborator
There was a problem hiding this comment.
Thank you for providing this PR! I have a few suggestions:
- Could you please add some tests to verify that the changes work correctly? For instance, it would be helpful to test edge cases such as invalid names, Go keywords, or names starting with a number. Additionally, would you mind checking the documentation and updating the support for custom package names if needed? If you want me to help with the validation functions, I’ll be happy to do so!
- I noticed that your code ensures the default package name is "main". However, I'm a bit unclear about line 149 — it still returns "main" when the package name is empty. Could you help me understand the reasoning behind this? (I might be missing something here, so please feel free to correct me if I'm mistaken.)
Also cc @ihciah
Author
|
|
i think this change is necessary to make this tool useful (very unlikely main will be used in anything other than an example) any chance this could be merged? thank you! |
Collaborator
|
@ihciah Can you help review this PR? Looks like it’s reasonable and effective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to use generated file from within a library and I cannot have package main there.