Replace Perl call with libcrypt#651
Open
misaochan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcrypt.so.1directly viactypesinstead of spawning Perl. The password is passed as raw bytes to the C function.threading.Lock()around thecrypt()call. Without the lock, concurrent AUTHENTICATE requests caused a segfault during testing.Libcrypt maintenance
libcrypt.so.1is provided bylibxcrypt(Ubuntu core package). This is unrelated to Python's removedcryptstdlib module or thecrypt_rpypi replacement - we call the C library directly viactypes, bypassing that issue entirely.libxcryptis actively maintained and ships on all modern Ubuntu/Debian systems.Tests
wrongpass); echo 0 #returns "User or Password Incorrect" with no server-side execution