-
Notifications
You must be signed in to change notification settings - Fork 1
Add contributor docs and CI #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zavianx
wants to merge
1
commit into
iii-experimental:main
Choose a base branch
from
Zavianx:docs-ci-contributor-start
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
|
|
||
| env: | ||
| CARGO_TERM_COLOR: always | ||
|
|
||
| jobs: | ||
| rust: | ||
| name: Rust | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install Rust | ||
| run: | | ||
| rustup toolchain install stable --profile minimal --component rustfmt,clippy | ||
| rustup default stable | ||
|
|
||
| - name: Check formatting | ||
| run: cargo fmt --all -- --check | ||
|
|
||
| - name: Run clippy | ||
| run: cargo clippy --all-targets -- -D warnings | ||
|
|
||
| - name: Run tests | ||
| run: cargo test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Contributing | ||
|
|
||
| Thanks for taking the time to improve `iii-code`. | ||
|
|
||
| `iii-code` is intentionally a thin Rust CLI over the installed `iii` binary and | ||
| the public worker stack. Contributions should preserve that boundary: prefer | ||
| terminal UX, payload construction, diagnostics, and documentation changes over | ||
| embedding another agent runtime in this repository. | ||
|
|
||
| ## Development Setup | ||
|
|
||
| Install the Rust stable toolchain, then check the project locally: | ||
|
|
||
| ```bash | ||
| cargo fmt --all -- --check | ||
| cargo clippy --all-targets -- -D warnings | ||
| cargo test | ||
| ``` | ||
|
|
||
| The default test suite does not require a running `iii` engine. The ignored | ||
| smoke test exercises the real engine and worker stack: | ||
|
|
||
| ```bash | ||
| cp config.example.yaml config.yaml | ||
| iii worker add harness | ||
| iii | ||
| cargo test -- --ignored | ||
| ``` | ||
|
|
||
| Run `iii` from the repository root so the example shell filesystem settings are | ||
| jailed to the same directory as the checkout. | ||
|
|
||
| ## Pull Requests | ||
|
|
||
| Keep pull requests focused and include: | ||
|
|
||
| - the user-facing behavior or documentation change | ||
| - the commands you ran, including skipped checks if any | ||
| - any required `iii` engine, worker, or provider credential assumptions | ||
|
|
||
| Good first changes include: | ||
|
|
||
| - README and troubleshooting improvements | ||
| - CLI formatting and diagnostics | ||
| - tests for argument parsing, payload construction, event rendering, and error | ||
| redaction | ||
| - small terminal UX improvements listed in | ||
| [docs/feature-parity-gaps.md](docs/feature-parity-gaps.md) | ||
|
|
||
| Before opening a larger feature, start with an issue or discussion so the | ||
| worker boundary and public `iii` contracts are clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set explicit workflow token permissions (least privilege).
Add top-level
permissionsso this job only gets read access it needs; this reduces CI token blast radius if an action/step is compromised.Suggested change
name: CI on: push: branches: - main pull_request: +permissions: + contents: read + env: CARGO_TERM_COLOR: always📝 Committable suggestion
🤖 Prompt for AI Agents