Check partial-application bound arguments in the creating scope#182
Closed
iliaal wants to merge 5 commits into
Closed
Check partial-application bound arguments in the creating scope#182iliaal wants to merge 5 commits into
iliaal wants to merge 5 commits into
Conversation
Assert and take advantage of that size is always 1. This is also documented in [the curl docs](https://curl.se/libcurl/c/CURLOPT_READFUNCTION.html). So there is no need to multiply with size, so this can be removed. I started this to see whether size * nmemb can overflow. This makes it clear that it cannot.
And instead let the normal docref error handling code handle arguments
As it now only has a single usage
…or() It's always NULL
Bound-argument type checks in zp_bind() resolved strict_types from
ZEND_ARG_USES_STRICT_TYPES(), which reads the caller of the frame
creating the partial rather than the file where the partial is written,
so the same f("3", ?) threw at one call depth and silently coerced at
another, and the TypeError named the enclosing function instead of the
target. Pass the creating frame's strict_types explicitly and attribute
the error to the target function.
iliaal
force-pushed
the
fix/pfa-bound-arg-strict-types
branch
from
July 17, 2026 14:59
189f0c7 to
ba1b308
Compare
Owner
Author
|
Promoted upstream: php#22789. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bound-argument type check in zp_bind() resolved strict_types from ZEND_ARG_USES_STRICT_TYPES(), which reads the caller of the frame creating the partial rather than the file where the partial is written. So the same f("3", ?) under strict_types=1 threw when written inside a function but silently coerced at top level, and the resulting TypeError named the enclosing function rather than the target. This passes the creating frame's strict_types into the check via ZEND_FLF_ARG_USES_STRICT_TYPES and attributes the error to the target function with zend_argument_type_error_ex.
The RFC does not specify creation-time bound-argument type-check semantics, so the proposed behavior (check eagerly against the creating scope's strict_types, with the error attributed to the target function) is a proposal for confirmation, not a settled fix.