Skip to content

Fix remote mobile control visibility gate#319

Merged
ilysenko merged 2 commits into
ilysenko:mainfrom
mkaoudis:fix/remote-mobile-control-visibility
May 27, 2026
Merged

Fix remote mobile control visibility gate#319
ilysenko merged 2 commits into
ilysenko:mainfrom
mkaoudis:fix/remote-mobile-control-visibility

Conversation

@mkaoudis
Copy link
Copy Markdown
Contributor

@mkaoudis mkaoudis commented May 27, 2026

Summary

  • patch the current use-plugin-install-flow visibility bundle for remote mobile control
  • preserve the upstream accessRequired guard while allowing Linux hosts to expose the connection UI
  • add coverage for the current bundle name/pattern and gate shape

Review order

This PR should be reviewed after #322 lands or main otherwise gets the same PR-only Nix rollout handling. The code change is independent, but its current Nix check is red only because upstream Codex.dmg metadata is ahead of the committed flake pins.

Why / user-visible behavior

  • The current upstream bundle moved the remote-control visibility gate into use-plugin-install-flow, so the opt-in Linux mobile remote-control feature can miss the connection UI.
  • With linux-features/remote-mobile-control enabled, Linux hosts can expose the mobile remote-control connection UI while still respecting upstream accessRequired state.

Scope and limitations

  • This stays inside the opt-in linux-features/remote-mobile-control feature and does not enable the feature by default.
  • No committed features.example.json, distro packaging, installer, or updater behavior changes are included.
  • Unrelated upstream/Nix pin drift is left out of scope for separate maintenance changes.

Source of truth

  • linux-features/remote-mobile-control/patch.js
  • linux-features/remote-mobile-control/test.js

Test plan

  • node --test linux-features/remote-mobile-control/test.js
  • node --test scripts/patch-linux-window-ui.test.js
  • git diff --check origin/main..HEAD

CI note

  • Current CI has Debian/RPM/pacman packaging and Rust/smoke tests passing.
  • The remaining Nix Package Builds failure is from validate-nix-pins.sh reporting an upstream DMG app-version pin mismatch: expected 26.519.81530, got 26.519.41501. That happens before this feature patch is exercised and is addressed by fix(ci): tolerate upstream DMG rollout in PR Nix checks #322.

@ilysenko ilysenko marked this pull request as ready for review May 27, 2026 05:42
Copy link
Copy Markdown
Owner

@ilysenko ilysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the updated head after rebasing onto current main. The remote-mobile-control patch stays scoped to the opt-in linux-feature, local tests pass, and the fresh CI run is green.

@ilysenko ilysenko merged commit 81266c1 into ilysenko:main May 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants