Skip to content

Reject stub managed Node runtimes#325

Merged
ilysenko merged 1 commit into
ilysenko:mainfrom
remybanks77:codex/managed-node-runtime-probe
May 27, 2026
Merged

Reject stub managed Node runtimes#325
ilysenko merged 1 commit into
ilysenko:mainfrom
remybanks77:codex/managed-node-runtime-probe

Conversation

@remybanks77
Copy link
Copy Markdown
Contributor

@remybanks77 remybanks77 commented May 27, 2026

Summary

First focused split from the larger closed #313 branch, following maintainer guidance to break the work into smaller PRs.

  • Changes the managed Node runtime probe from node -v to a real node -e execution check.
  • Rejects version-only stub binaries that print a version but cannot execute JavaScript.
  • Adds smoke coverage proving an existing stub runtime is replaced by a real managed runtime source.

Validation

Local on 9e6ef10:

  • bash -n tests/scripts_smoke.sh
  • git diff --check origin/main...HEAD
  • bash tests/scripts_smoke.sh -> all script smoke tests passed

GitHub on 9e6ef10:

  • CI run 26493942582 passed.

Notes

This is intentionally narrow: scripts/lib/node-runtime.sh plus its smoke tests only.

Copy link
Copy Markdown
Owner

@ilysenko ilysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head and verified the managed Node runtime probe change plus smoke coverage. This is narrow and safe to merge.

@ilysenko ilysenko merged commit 527dfb4 into ilysenko:main May 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants