Skip to content

Improve open-target-discovery TryExec handling#327

Merged
ilysenko merged 1 commit into
ilysenko:mainfrom
ohnicholas93:feat/harden-open-target-discovery
May 27, 2026
Merged

Improve open-target-discovery TryExec handling#327
ilysenko merged 1 commit into
ilysenko:mainfrom
ohnicholas93:feat/harden-open-target-discovery

Conversation

@ohnicholas93
Copy link
Copy Markdown
Contributor

Summary

Focused follow-up to the closed #309 branch, following guidance to keep this work inside the existing opt-in linux-features/open-target-discovery feature.

This keeps the feature disabled unless explicitly listed in linux-features/features.json, and narrows the contribution to safer Linux desktop-entry discovery behavior.

Changes

  • Improves TryExec evaluation for Linux desktop entries discovered by open-target-discovery.
  • Handles shell wrappers, env wrappers, Flatpak info / run probes, path expansion, and wrapper-only false positives more conservatively.
  • Keeps Flatpak and shell probe handling fail-closed when the result cannot be statically verified.
  • Adds focused discovery-level and parser-level regression coverage without a large desktop-entry matrix.

Copy link
Copy Markdown
Owner

@ilysenko ilysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head carefully. The change stays inside the disabled-by-default open-target-discovery feature, hardens TryExec handling fail-closed, and has focused regression coverage.

@ilysenko ilysenko merged commit 05f9529 into ilysenko:main May 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants