Improve open-target-discovery TryExec handling#327
Merged
ilysenko merged 1 commit intoMay 27, 2026
Conversation
ilysenko
approved these changes
May 27, 2026
Owner
ilysenko
left a comment
There was a problem hiding this comment.
Reviewed the current head carefully. The change stays inside the disabled-by-default open-target-discovery feature, hardens TryExec handling fail-closed, and has focused regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Focused follow-up to the closed #309 branch, following guidance to keep this work inside the existing opt-in
linux-features/open-target-discoveryfeature.This keeps the feature disabled unless explicitly listed in
linux-features/features.json, and narrows the contribution to safer Linux desktop-entry discovery behavior.Changes
TryExecevaluation for Linux desktop entries discovered byopen-target-discovery.info/runprobes, path expansion, and wrapper-only false positives more conservatively.