Rename Hostname/Device Name commands and add ERROR_BAD_HOSTNAME#36
Merged
jesserockz merged 1 commit intoJun 16, 2026
Merged
Conversation
Renames GET_SET_HOSTNAME -> HOSTNAME and GET_SET_DEVICE_NAME -> DEVICE_NAME (values unchanged at 0x05/0x06) to match the naming used by the in-flight Improv 2.4 work (improv-wifi#32), so that change rebases cleanly. Also adds the spec's ERROR_BAD_HOSTNAME (0x05), returned when a provided hostname is unacceptable.
jesserockz
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #35 to align with the in-flight Improv 2.4 work in #32 (so #32 rebases cleanly):
GET_SET_HOSTNAME→HOSTNAMEandGET_SET_DEVICE_NAME→DEVICE_NAME(values unchanged,0x05/0x06) — matches the names used in Update for Improv 2.4 commands/capabilities #32.ERROR_BAD_HOSTNAME = 0x05to theErrorenum (spec: returned when a provided hostname is unacceptable), which Update for Improv 2.4 commands/capabilities #32 also adds.Purely the enum names/values + the new error constant; no handler/parse changes (those remain part of #32). This keeps the
Command/Errorenums inmainmatching what #32 expects, so its rebase is trivial.