Skip to content

[FIX] [IPv6] Use correct destination address so packets with multicast destination are properly handled #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgonzalezlopezudc wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

[FIX] [IPv6] Use correct destination address so packets with multicast destination are properly handled #1104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/inet/networklayer/ipv6/Ipv6.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,10 @@ void Ipv6::datagramLocalOut(Packet *packet, const NetworkInterface *destIE, Ipv6
const auto& ipv6Header = packet->peekAtFront<Ipv6Header>();
// route packet
if (destIE != nullptr)
fragmentPostRouting(packet, destIE, MacAddress::BROADCAST_ADDRESS, true); // FIXME what MAC address to use?
if(!ipv6Header->getDestAddress().isMulticast())
fragmentPostRouting(packet, destIE, MacAddress::BROADCAST_ADDRESS, true);
else
fragmentPostRouting(packet, destIE, ipv6Header->getDestAddress().mapToMulticastMacAddress(), true);
else if (!ipv6Header->getDestAddress().isMulticast())
routePacket(packet, destIE, nullptr, requestedNextHopAddress, true);
else
Expand Down Expand Up @@ -602,7 +605,7 @@ void Ipv6::routeMulticastPacket(Packet *packet, const NetworkInterface *destIE,
for (int i = 0; i < ift->getNumInterfaces(); i++) {
NetworkInterface *ie = ift->getInterface(i);
if (fromIE != ie && !ie->isLoopback())
fragmentPostRouting(packet->dup(), ie, MacAddress::BROADCAST_ADDRESS, fromHL);
fragmentPostRouting(packet->dup(), ie, ipv6Header->getDestAddress().mapToMulticastMacAddress(), fromHL);
}
delete packet;

Expand Down
Loading