Skip to content

Feat: add cell type coercion for Excel export#13808

Merged
yingfeng merged 1 commit intoinfiniflow:mainfrom
tecpie:feature/excel_number
Apr 13, 2026
Merged

Feat: add cell type coercion for Excel export#13808
yingfeng merged 1 commit intoinfiniflow:mainfrom
tecpie:feature/excel_number

Conversation

@huang-aoqin
Copy link
Copy Markdown
Contributor

@huang-aoqin huang-aoqin commented Mar 26, 2026

What problem does this PR solve?

  • Implemented a helper function to convert markdown cell text to native numeric types for Excel output.
  • Ensured that leading zeros are preserved and handled various numeric formats, including those with thousand separators and scientific notation.

Type of change

  • New Feature (non-breaking change which adds functionality)

- Implemented a helper function to convert markdown cell text to native numeric types for Excel output.
- Ensured that leading zeros are preserved and handled various numeric formats, including those with thousand separators and scientific notation.
- Updated the message processing logic to apply this coercion before appending rows.
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 26, 2026
@yingfeng yingfeng added the ci Continue Integration label Mar 26, 2026
@yingfeng yingfeng marked this pull request as draft March 26, 2026 08:51
@yingfeng yingfeng marked this pull request as ready for review March 26, 2026 08:52
@yingfeng yingfeng requested a review from Magicbook1108 March 26, 2026 08:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.72%. Comparing base (456b1bb) to head (280e40d).
⚠️ Report is 166 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13808       +/-   ##
===========================================
+ Coverage   48.72%   96.72%   +48.00%     
===========================================
  Files          45       10       -35     
  Lines        9895      702     -9193     
  Branches      112      112               
===========================================
- Hits         4821      679     -4142     
+ Misses       5064        5     -5059     
- Partials       10       18        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yingfeng yingfeng merged commit 356d45f into infiniflow:main Apr 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continue Integration size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants