Skip to content

chore(MangaDex): Restructuring, bug fixes, and improvements#192

Open
kymotsujason wants to merge 1 commit into
inkdex:0.9/stablefrom
kymotsujason:chore/mangadex-restructuring
Open

chore(MangaDex): Restructuring, bug fixes, and improvements#192
kymotsujason wants to merge 1 commit into
inkdex:0.9/stablefrom
kymotsujason:chore/mangadex-restructuring

Conversation

@kymotsujason
Copy link
Copy Markdown
Contributor

@kymotsujason kymotsujason commented May 24, 2026

Summary

Restructures the MangaDex extension into the proper implementations/ and services/ directory format specified in the contributing guidelines, and ships a batch of bug fixes and improvements. Some key changes are actual HTTP status code error handling, legacy numeric ID resolution to current UUIDs, state management changed to the more intuitive getters/setters, the static tag.json is replaced with dynamically updated API calls, and the unused progress providing capability and unstable image cropping were removed.

Checklist

Making changes

For updates to existing extensions

  • Bumped the version value in pbconfig.ts for each modified extension.

For new extensions

  • Generated tests with npx paperback-cli test --generate EXTENSION_NAME.

Testing changes

  • npm run conformance passes.
  • npm test -- EXTENSION_NAME passes.
  • Bundled the extension and verified it works in the Paperback app.

Committing changes

  • Commit messages follow the existing convention (type(Scope): summary, e.g. fix(EXTENSION_NAME): ...).

AI assistance

Pick one:

  • This PR contains no AI-assisted changes.
  • This PR is AI-assisted. I manually reviewed every change and added an Assisted-by: AGENT_NAME:MODEL_VERSION trailer to each AI-assisted commit.

@celarye
Copy link
Copy Markdown
Contributor

celarye commented May 24, 2026

Just a small nitpick, I think the more correct thing was to use feat(MangaDex): ... or refactor(MangaDex): ....

It contains chore, fix, feature, and refactor changes so you pick the one with the highest effect on semver, which is feat or refactor which would result in a minor bump in semver.

fix results in a patch bump and technically chore results in no bump at all iirc (although we still do this incorrectly ourselves from time to time).

@kymotsujason
Copy link
Copy Markdown
Contributor Author

Yea I'd agree with you on that. Refactor would've been a better choice, I just didn't think of it. It was feature first, but that didn't quite seem right.

@niclimcy
Copy link
Copy Markdown
Contributor

It seems like your Assisted-by commit trailer is a bit wrong, it should also indicate the tool used for each, delimiting each tool by spaces:

Assisted-by: ClaudeCode:claude-opus-4.7 AntiGravity:gemini-3.1-pro Codex:gpt-5.5

And as this is a commit trail, this should be added at the end of your commit message instead of the start

@kymotsujason
Copy link
Copy Markdown
Contributor Author

Oh right, I forgot the CLI tools were also called agents. I assumed agent meant model, I'll force push a commit message change

- Add real status code handling so MangaDex server errors display proper errors
- Add legacy ID resolution so old numeric manga and chapter IDs map to current UUIDs
- Add Keiyoushi features (mainly search)
- Improve parsing safety
- Update directory format to match contributing guideline
- Update search form from compat
- Update discovery section with dynamic list ID updates
- Fix implicit any
- Fix and tighten authentication (MangaDex API enforcement)
- Replace bundled tags file with API calls
- Replace state management with inline setters and getters
- Remove broken WebViewRow
- Remove useless progress providing capability
- Remove image border cropping (too slow in JSCore)
- Various optimizations and bug fixes

Assisted-by: ClaudeCode:claude-opus-4.7 AntiGravity:gemini-3.1-pro Codex:gpt-5.5
@kymotsujason kymotsujason force-pushed the chore/mangadex-restructuring branch from e398908 to 3e0b92a Compare May 24, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants