Skip to content

export: mf_col_widths#374

Merged
Melkiades merged 2 commits into
insightsengineering:mainfrom
munoztd0:exports_junco
May 21, 2026
Merged

export: mf_col_widths#374
Melkiades merged 2 commits into
insightsengineering:mainfrom
munoztd0:exports_junco

Conversation

@munoztd0
Copy link
Copy Markdown
Contributor

@munoztd0 munoztd0 commented May 7, 2026

junco uses mf_col_widths. To use a public, stable API and avoid relying on unexported internal symbols, can we consider exporting mf_col_widths in the next release?

I have added a test for it.

See -> johnsonandjohnson/junco#317

Co-authored-by: Copilot <copilot@github.com>
@Melkiades Melkiades removed the request for review from ayogasekaram May 8, 2026 11:24
Copy link
Copy Markdown
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Check only the spelling is failing. Thanks :)

@munoztd0
Copy link
Copy Markdown
Contributor Author

Looks good to me! Check only the spelling is failing. Thanks :)

Fixed it, my bad!

@Melkiades Melkiades enabled auto-merge (squash) May 13, 2026 15:08
@Melkiades Melkiades merged commit 5319bea into insightsengineering:main May 21, 2026
28 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
@Melkiades
Copy link
Copy Markdown
Contributor

Apologies forgot to approve it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants