Pyramid: capture responseHeadersOnEntrySpans#496
Merged
Conversation
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Ferenc-
reviewed
Jan 10, 2024
Ferenc-
reviewed
Jan 10, 2024
Ferenc-
reviewed
Jan 10, 2024
Ferenc-
reviewed
Jan 10, 2024
Ferenc-
requested changes
Jan 10, 2024
Ferenc-
left a comment
Ferenc-
left a comment
Member
There was a problem hiding this comment.
It appears that the request header capture feature, was previously implemented, but was not covered with UT.
And since this change potentially impacts that feature too, could we add coverage for that too?
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
- test(request_header_capture) Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Contributor
Author
For sure! Added coverage for capturing request headers in the latest commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pyramid: capture responseHeadersOnEntrySpans
Signed-off-by: Varsha GS varsha.gs@ibm.com
References
Why
According to our spec, tracers SHOULD capture all four flavours of HTTP headers.