Skip to content

refactor(tests): Remove superfluous imports#504

Merged
GSVarsha merged 4 commits into
masterfrom
cleanup-2.0
Feb 15, 2024
Merged

refactor(tests): Remove superfluous imports#504
GSVarsha merged 4 commits into
masterfrom
cleanup-2.0

Conversation

@GSVarsha

Copy link
Copy Markdown
Contributor

Follow up PR for #503

@GSVarsha GSVarsha self-assigned this Feb 14, 2024
@GSVarsha GSVarsha requested review from Ferenc- and pvital February 14, 2024 13:15

@Ferenc- Ferenc- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Perhaps a few extra lines could be shedded.

Comment thread instana/collector/base.py Outdated
Comment thread instana/util/ids.py Outdated

@Ferenc- Ferenc- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
- remove PY2

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha merged commit a8aad4d into master Feb 15, 2024
@GSVarsha GSVarsha deleted the cleanup-2.0 branch February 15, 2024 10:29
@GSVarsha GSVarsha added this to the H1-2024 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants