Skip to content

Otel: span and span_context changes#557

Merged
pvital merged 5 commits into
otel_migrationfrom
otel-span-update
Jul 20, 2024
Merged

Otel: span and span_context changes#557
pvital merged 5 commits into
otel_migrationfrom
otel-span-update

Conversation

@GSVarsha

@GSVarsha GSVarsha commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

Changes made to:

  • span context
  • span.d / span.duration
  • span.stack

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha self-assigned this Jul 19, 2024
@GSVarsha GSVarsha added this to the H2-2024 milestone Jul 19, 2024
@GSVarsha GSVarsha force-pushed the otel-span-update branch 2 times, most recently from e3f4111 to 3aec8b2 Compare July 19, 2024 15:19
GSVarsha added 2 commits July 19, 2024 20:59
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
GSVarsha added 2 commits July 19, 2024 21:50
- start_span() and start_as_current_span() should receive SpanContext obj as span_context
- extract() should return SpanContext obj as span_context

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha added Review & Merge OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Jul 19, 2024
@GSVarsha GSVarsha marked this pull request as ready for review July 19, 2024 16:22
@GSVarsha GSVarsha requested a review from pvital July 19, 2024 16:24

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@pvital pvital merged commit 40c24d1 into otel_migration Jul 20, 2024
@pvital pvital deleted the otel-span-update branch July 20, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry Review & Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants