Skip to content

Fix: context propagation in nested spans#589

Merged
GSVarsha merged 1 commit into
otel_migrationfrom
fix_nested_span_context
Aug 19, 2024
Merged

Fix: context propagation in nested spans#589
GSVarsha merged 1 commit into
otel_migrationfrom
fix_nested_span_context

Conversation

@GSVarsha

Copy link
Copy Markdown
Contributor

Signed-off-by: Varsha GS varsha.gs@ibm.com

Fix: context propagation in nested spans

@GSVarsha GSVarsha added bug Review & Merge OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Aug 19, 2024
@GSVarsha GSVarsha added this to the H2-2024 milestone Aug 19, 2024
@GSVarsha GSVarsha self-assigned this Aug 19, 2024
@GSVarsha GSVarsha requested review from CagriYonca and pvital August 19, 2024 07:08

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @GSVarsha. Just a simple request.

Comment thread src/instana/tracer.py Outdated
@GSVarsha GSVarsha force-pushed the fix_nested_span_context branch from ddc7c7f to 5c10c73 Compare August 19, 2024 07:52
@GSVarsha GSVarsha requested a review from pvital August 19, 2024 07:53

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@CagriYonca CagriYonca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha force-pushed the fix_nested_span_context branch from 5c10c73 to bab662a Compare August 19, 2024 11:07
@GSVarsha GSVarsha merged this pull request into otel_migration Aug 19, 2024
@GSVarsha GSVarsha deleted the fix_nested_span_context branch August 19, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry Review & Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants