[OTel] Refactor of pymysql implementation#598
Merged
Conversation
CagriYonca
commented
Aug 26, 2024
CagriYonca
commented
Contributor
- 100% coverage
CagriYonca
added
the
OTel_migration
GSVarsha
reviewed
Aug 28, 2024
GSVarsha
reviewed
Aug 28, 2024
GSVarsha
reviewed
Aug 28, 2024
CagriYonca
force-pushed
the
otel/pymysql
branch
from
523fe82 to
4cbae60
Compare
CagriYonca
changed the title
pvital
force-pushed
the
otel_migration
branch
from
7ec6824 to
3746294
Compare
CagriYonca
force-pushed
the
otel/pymysql
branch
2 times, most recently
from
226fa8c to
81c1863
Compare
pvital
requested changes
Sep 2, 2024
Member
|
One more thing, are you not forgetting to remove the following line from the
|
CagriYonca
force-pushed
the
otel/pymysql
branch
from
22fb23f to
414e0cd
Compare
Signed-off-by: Cagri Yonca <cagriyonca@gmail.com>
Signed-off-by: Cagri Yonca <cagriyonca@gmail.com>
CagriYonca
force-pushed
the
otel/pymysql
branch
from
414e0cd to
609b3fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.