Skip to content

[OTel] Refactor redis instrumentation#608

Merged
CagriYonca merged 2 commits into
otel_migrationfrom
otel/redis
Sep 19, 2024
Merged

[OTel] Refactor redis instrumentation#608
CagriYonca merged 2 commits into
otel_migrationfrom
otel/redis

Conversation

@CagriYonca

Copy link
Copy Markdown
Contributor

Coverage: 92%

@CagriYonca CagriYonca added the OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry label Sep 4, 2024
@CagriYonca CagriYonca added this to the H2-2024 milestone Sep 4, 2024
@CagriYonca CagriYonca self-assigned this Sep 4, 2024

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few 😬 requests.

Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread tests/clients/test_redis.py Outdated
Comment thread tests/clients/test_redis.py Outdated
Comment thread tests/clients/test_redis.py Outdated
Comment thread tests/clients/test_redis.py Outdated
Comment thread tests/clients/test_redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread tests/helpers.py Outdated

@GSVarsha GSVarsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests

@CagriYonca CagriYonca force-pushed the otel/redis branch 2 times, most recently from 8723c1e to 7e401e0 Compare September 5, 2024 07:34
@CagriYonca CagriYonca requested a review from GSVarsha September 5, 2024 07:36
@CagriYonca CagriYonca force-pushed the otel/redis branch 3 times, most recently from d1e95df to 2c1e7a4 Compare September 9, 2024 14:50

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions.

Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread tests/helpers.py Outdated

@GSVarsha GSVarsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion.

Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread src/instana/instrumentation/redis.py Outdated
Comment thread tests/helpers.py Outdated
@CagriYonca CagriYonca force-pushed the otel/redis branch 2 times, most recently from aae9f2f to 48c8db6 Compare September 18, 2024 09:43
@CagriYonca CagriYonca requested a review from GSVarsha September 18, 2024 09:48

@GSVarsha GSVarsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CagriYonca CagriYonca merged commit d087f7a into otel_migration Sep 19, 2024
@CagriYonca CagriYonca deleted the otel/redis branch September 19, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants