Skip to content

[OTel] Refactor couchbase instrumentation#611

Merged
CagriYonca merged 2 commits into
otel_migrationfrom
otel/couchbase
Sep 18, 2024
Merged

[OTel] Refactor couchbase instrumentation#611
CagriYonca merged 2 commits into
otel_migrationfrom
otel/couchbase

Conversation

@CagriYonca

Copy link
Copy Markdown
Contributor

Coverage: 96%

@CagriYonca CagriYonca added the OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry label Sep 9, 2024
@CagriYonca CagriYonca added this to the H2-2024 milestone Sep 9, 2024
@CagriYonca CagriYonca self-assigned this Sep 9, 2024

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions.

Comment thread src/instana/instrumentation/couchbase_inst.py Outdated
Comment thread src/instana/instrumentation/couchbase_inst.py Outdated
Comment thread src/instana/instrumentation/couchbase_inst.py Outdated
Comment thread src/instana/instrumentation/couchbase_inst.py Outdated
Comment thread src/instana/instrumentation/couchbase_inst.py Outdated
Comment thread src/instana/instrumentation/couchbase_inst.py Outdated

@GSVarsha GSVarsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion.

@CagriYonca CagriYonca requested a review from GSVarsha September 13, 2024 09:39

@GSVarsha GSVarsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@CagriYonca CagriYonca merged commit 8dee449 into otel_migration Sep 18, 2024
@CagriYonca CagriYonca deleted the otel/couchbase branch September 18, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants