Skip to content

[OTel] Pyramid instrumentation#619

Merged
GSVarsha merged 4 commits into
otel_migrationfrom
otel-pyramid-instrumentation
Sep 21, 2024
Merged

[OTel] Pyramid instrumentation#619
GSVarsha merged 4 commits into
otel_migrationfrom
otel-pyramid-instrumentation

Conversation

@GSVarsha

@GSVarsha GSVarsha commented Sep 12, 2024

Copy link
Copy Markdown
Contributor
  • enable auto-instrumentation
  • consider both implicit and explicit tween ordering

coverage: 96%

Signed-off-by: Varsha GS varsha.gs@ibm.com

@GSVarsha GSVarsha added WIP work in progress OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Sep 12, 2024
@GSVarsha GSVarsha added this to the H2-2024 milestone Sep 12, 2024
@GSVarsha GSVarsha self-assigned this Sep 12, 2024
@GSVarsha GSVarsha force-pushed the otel-pyramid-instrumentation branch from 345aeda to 167128d Compare September 17, 2024 14:28
@GSVarsha GSVarsha marked this pull request as ready for review September 17, 2024 14:30
@GSVarsha GSVarsha removed the WIP work in progress label Sep 17, 2024
@GSVarsha GSVarsha force-pushed the otel-pyramid-instrumentation branch from 167128d to 990be43 Compare September 17, 2024 15:02
Comment thread src/instana/__init__.py Outdated
Comment thread src/instana/instrumentation/pyramid_inst.py Outdated
Comment thread src/instana/instrumentation/pyramid_inst.py Outdated
Comment thread src/instana/instrumentation/pyramid_inst.py Outdated
Comment thread src/instana/instrumentation/pyramid_inst.py Outdated
Comment thread src/instana/instrumentation/pyramid_inst.py Outdated
Comment thread tests/frameworks/test_pyramid.py Outdated
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
(cherry picked from commit 8ab3210a92502253876f91213009c287167f6790)
(cherry picked from commit 126e4ec09440509da867e7b7aa49dfaf0c8a867d)
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha force-pushed the otel-pyramid-instrumentation branch from 990be43 to 6f2379f Compare September 20, 2024 09:37
@GSVarsha GSVarsha requested a review from CagriYonca September 20, 2024 09:39

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

Comment thread src/instana/instrumentation/pyramid_inst.py Outdated
Comment thread src/instana/instrumentation/pyramid_inst.py Outdated
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha force-pushed the otel-pyramid-instrumentation branch from 6f2379f to 10f6291 Compare September 21, 2024 05:22
@GSVarsha GSVarsha requested a review from pvital September 21, 2024 05:22

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 863cf9b into otel_migration Sep 21, 2024
@GSVarsha GSVarsha deleted the otel-pyramid-instrumentation branch September 21, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry Review & Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants