[OTel] PubSub & Cloud Storage instrumentation#623
Merged
Conversation
CagriYonca
commented
Sep 20, 2024
CagriYonca
commented
Contributor
- Pubsub coverage: 90%
- Cloud Storage coverage: 91%
CagriYonca
added
the
OTel_migration
CagriYonca
force-pushed
the
otel/gcloud
branch
from
1351482 to
bbb1fac
Compare
GSVarsha
reviewed
Sep 24, 2024
GSVarsha
reviewed
Sep 24, 2024
GSVarsha
reviewed
Sep 24, 2024
GSVarsha
left a comment
GSVarsha
left a comment
Contributor
There was a problem hiding this comment.
A few minor requests. If there are other higher priority tasks, please feel free to make these changes later as well.
pvital
requested changes
Sep 25, 2024
pvital
force-pushed
the
otel_migration
branch
from
e3eb9a0 to
fd82b29
Compare
CagriYonca
force-pushed
the
otel/gcloud
branch
3 times, most recently
from
4594648 to
bfcb741
Compare
CagriYonca
force-pushed
the
otel/gcloud
branch
from
bfcb741 to
b9effb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.