Skip to content

[OTel] Celery instrumentation#633

Merged
pvital merged 2 commits into
otel_migrationfrom
otel/celery_inst
Sep 30, 2024
Merged

[OTel] Celery instrumentation#633
pvital merged 2 commits into
otel_migrationfrom
otel/celery_inst

Conversation

@CagriYonca

Copy link
Copy Markdown
Contributor
  • Coverage: 87%

@CagriYonca CagriYonca self-assigned this Sep 26, 2024
@CagriYonca CagriYonca added this to the H2-2024 milestone Sep 26, 2024
@CagriYonca CagriYonca added the OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry label Sep 26, 2024

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests

Comment thread src/instana/instrumentation/celery_inst.py Outdated
Comment thread src/instana/instrumentation/celery_inst.py Outdated
Comment thread src/instana/instrumentation/celery_inst.py Outdated
Comment thread src/instana/instrumentation/celery_inst.py Outdated
Comment thread src/instana/instrumentation/celery_inst.py Outdated
Comment thread src/instana/instrumentation/celery_inst.py Outdated
Comment thread src/instana/instrumentation/celery_inst.py Outdated
Comment thread src/instana/instrumentation/celery_inst.py Outdated
Comment thread src/instana/instrumentation/celery_inst.py Outdated
Comment thread tests/span/test_span.py Outdated
@CagriYonca CagriYonca force-pushed the otel/celery_inst branch 2 times, most recently from 7638cdf to 44fc071 Compare September 29, 2024 20:32
@CagriYonca

Copy link
Copy Markdown
Contributor Author

Firstly we should merge this PR

@CagriYonca CagriYonca requested a review from pvital September 30, 2024 00:00

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
Need a rebase before merging.

@pvital pvital merged commit b064ec6 into otel_migration Sep 30, 2024
@pvital pvital deleted the otel/celery_inst branch September 30, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants