Skip to content

Fix: CI errors with sanic#749

Merged
GSVarsha merged 2 commits into
mainfrom
fix-sanic-errors
Jun 18, 2025
Merged

Fix: CI errors with sanic#749
GSVarsha merged 2 commits into
mainfrom
fix-sanic-errors

Conversation

@GSVarsha

Copy link
Copy Markdown
Contributor
venv/lib/python3.9/site-packages/sanic/pages/error.py:4: in <module>
    import tracerite.html
venv/lib/python3.9/site-packages/tracerite/__init__.py:1: in <module>
    from .html import html_traceback
venv/lib/python3.9/site-packages/tracerite/html.py:3: in <module>
    from .trace import extract_chain
venv/lib/python3.9/site-packages/tracerite/trace.py:11: in <module>
    from .inspector import extract_variables
E     File "/root/repo/venv/lib/python3.9/site-packages/tracerite/inspector.py", line 119
E       except AttributeError, TypeError:
E                            ^
E   SyntaxError: invalid syntax

Error comes from this change that was released in the latest version (1.1.2) 5 hours ago in tracerite (sanic's dependency)

…ion `1.1.2`

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha added this to the H1-2025 milestone Jun 18, 2025
@GSVarsha GSVarsha self-assigned this Jun 18, 2025
@GSVarsha GSVarsha requested a review from a team as a code owner June 18, 2025 07:07

@arjun-rajappa arjun-rajappa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this logic to the dependency of python-sensor package? If someone uses sanic and tries to instrument it we may get the same error!

Comment thread tests/requirements-pre314.txt
@pvital

pvital commented Jun 18, 2025

Copy link
Copy Markdown
Member

Should we add this logic to the dependency of python-sensor package? If someone uses sanic and tries to instrument it we may get the same error!

I don't think it is necessary, since Sanic is not a direct dependency.

It's a supported framework, and if this is coming from a third-party dependency, probably this will be handled by Sanic or the original package.

@GSVarsha GSVarsha added WIP work in progress and removed Review & Merge labels Jun 18, 2025
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha requested review from arjun-rajappa and pvital June 18, 2025 10:01
@GSVarsha GSVarsha added Review & Merge ci/cd and removed WIP work in progress labels Jun 18, 2025

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit f84bf0d into main Jun 18, 2025
16 checks passed
@GSVarsha GSVarsha deleted the fix-sanic-errors branch June 18, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants