Fix: CI errors with sanic#749
Merged
Merged
Conversation
…ion `1.1.2` Signed-off-by: Varsha GS <varsha.gs@ibm.com>
arjun-rajappa
left a comment
Contributor
There was a problem hiding this comment.
Should we add this logic to the dependency of python-sensor package? If someone uses sanic and tries to instrument it we may get the same error!
pvital
requested changes
Jun 18, 2025
Member
I don't think it is necessary, since Sanic is not a direct dependency. It's a supported framework, and if this is coming from a third-party dependency, probably this will be handled by Sanic or the original package. |
2b08cc3 to
0b90334
Compare
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
0b90334 to
b76f926
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error comes from this change that was released in the latest version (1.1.2) 5 hours ago in
tracerite(sanic's dependency)