Skip to content

ci: Revert temporary fix for failures caused by sanic for python>3.8#750

Merged
GSVarsha merged 1 commit into
mainfrom
revert-temp-fix
Jun 23, 2025
Merged

ci: Revert temporary fix for failures caused by sanic for python>3.8#750
GSVarsha merged 1 commit into
mainfrom
revert-temp-fix

Conversation

@GSVarsha

@GSVarsha GSVarsha commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

New tracerite version 1.1.3 with the fix for this bug has been released. But a different bug still exists in tracerite-1.1.2 for python version 3.8

venv/lib/python3.8/site-packages/sanic/errorpages.py:27: in <module>
    from sanic.pages.error import ErrorPage
venv/lib/python3.8/site-packages/sanic/pages/error.py:3: in <module>
    import tracerite.html
venv/lib/python3.8/site-packages/tracerite/__init__.py:1: in <module>
    from .html import html_traceback
venv/lib/python3.8/site-packages/tracerite/html.py:5: in <module>
    from importlib.resources import files
E   ImportError: cannot import name 'files' from 'importlib.resources' (/usr/local/lib/python3.8/importlib/resources.py)

Signed-off-by: Varsha GS varsha.gs@ibm.com

@GSVarsha GSVarsha added this to the H1-2025 milestone Jun 23, 2025
@GSVarsha GSVarsha self-assigned this Jun 23, 2025
… in version `1.1.2`" for python version >= 3.9

Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha changed the title ci: Revert temporary fix for failures caused by sanic ci: Revert temporary fix for failures caused by sanic for python > 3.8 Jun 23, 2025
@GSVarsha GSVarsha changed the title ci: Revert temporary fix for failures caused by sanic for python > 3.8 ci: Revert temporary fix for failures caused by sanic for python>3.8 Jun 23, 2025
@GSVarsha GSVarsha marked this pull request as ready for review June 23, 2025 07:03
@GSVarsha GSVarsha requested a review from a team as a code owner June 23, 2025 07:03

@arjun-rajappa arjun-rajappa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 36b6782 into main Jun 23, 2025
17 checks passed
@GSVarsha GSVarsha deleted the revert-temp-fix branch June 23, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants