Skip to content

Fix stderr reporting when special cursor line isn't found#21

Merged
fourls merged 1 commit into
integrated-application-development:masterfrom
zaneduffield:fix-error-info
May 15, 2025
Merged

Fix stderr reporting when special cursor line isn't found#21
fourls merged 1 commit into
integrated-application-development:masterfrom
zaneduffield:fix-error-info

Conversation

@zaneduffield
Copy link
Copy Markdown
Contributor

An easy way to reproduce this issue is to run the plugin with an old
version of pasfmt from before the --cursor option was added. In this
case it will tell you an error occurred but won't be able to tell you
anything about it.

@zaneduffield zaneduffield requested a review from fourls April 9, 2025 05:30
@zaneduffield
Copy link
Copy Markdown
Contributor Author

How embarrassing... the code wasn't correctly formatted 😱

Copy link
Copy Markdown
Collaborator

@fourls fourls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Copy Markdown
Collaborator

@fourls fourls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually. could you add a changelog entry?

@zaneduffield zaneduffield force-pushed the fix-error-info branch 2 times, most recently from f4ce02f to 8db23c9 Compare May 14, 2025 04:33
@zaneduffield zaneduffield requested a review from fourls May 14, 2025 04:33
Comment thread CHANGELOG.md Outdated
An easy way to reproduce this issue is to run the plugin with an old
version of pasfmt from before the `--cursor` option was added. In this
case it will tell you an error occurred but won't be able to tell you
anything about it.
Copy link
Copy Markdown
Collaborator

@fourls fourls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fourls fourls merged commit 3e85143 into integrated-application-development:master May 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants