Add support for 'interface' and 'unmanaged' generic constraints#437
Open
Bazooper-blip wants to merge 2 commits into
Open
Conversation
Delphi 13 introduces two new generic constraint keywords: - 'interface': ensures type parameter implements an interface - 'unmanaged': ensures type parameter is a simple value type Adds full constraint pipeline: API interfaces, AST nodes, constraint implementations with cross-constraint compatibility, grammar rules, visitor methods, and comprehensive tests. Closes integrated-application-development#413, closes integrated-application-development#414 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cirras
requested changes
May 1, 2026
Collaborator
cirras
left a comment
cirras
left a comment
There was a problem hiding this comment.
These changes look good on the surface but don't entirely match reality and can't be accepted without some changes.
You should test your assumptions against an actual Delphi 13 compiler.
- Make incompatible constraint pairs return VIOLATED instead of COMPATIBLE/SATISFIED: - interface vs constructor (interfaces can't be instantiated) - record vs unmanaged (records can hold managed fields) - type-constraint vs unmanaged (class hierarchy is managed) - Rewrite UnmanagedConstraint type check: - Accept pointer types - For records, recursively verify every field is unmanaged itself - Remove invalid constraint combinations from grammar fixture - Update constraint tests for the new compatibility matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delphi 13 introduces two new generic constraint keywords:
Adds full constraint pipeline: API interfaces, AST nodes, constraint implementations with cross-constraint compatibility, grammar rules, visitor methods, and comprehensive tests.
Closes #413, closes #414