[clang][SYCL] Skip allocation diagnostic in unevaluated contexts#21614
[clang][SYCL] Skip allocation diagnostic in unevaluated contexts#21614schittir wants to merge 5 commits intointel:syclfrom
Conversation
This patch adds a check to avoid emitting "SYCL kernel cannot allocate storage" diagnostic in unevaluated contexts, such as for operator new expressions in C++20 concepts and requires clauses. This fixes false positive errors with GCC 13's standard library which uses concepts with ::new expressions.
|
@intel/dpcpp-cfe-reviewers Could you please review this? Thank you! |
|
I see that buildbot shows a precommit failure but I am unable to view the exact test that fails! Are any @intel/dpcpp-cfe-reviewers able to see it? |
I see this - |
|
The failing tests are unrelated to my changes. |
|
llvm> llvm-lit -v clang/test/Preprocessor/init.c Testing Time: 1.95s Total Discovered Tests: 1 |
|
@elizabethandrews @premanandrao Thank you for your review! Do you have any other comments? |
This patch adds a check to avoid emitting "SYCL kernel cannot allocate storage" diagnostic in unevaluated contexts, such as for operator new expressions in C++20 concepts and requires clauses.
This fixes false positive errors with GCC 13's standard library which uses concepts with ::new expressions.