Revert "[SYCL] Update device_global host access decoration (#21104)"#21658
Open
HPS-1 wants to merge 1 commit intointel:syclfrom
Open
Revert "[SYCL] Update device_global host access decoration (#21104)"#21658HPS-1 wants to merge 1 commit intointel:syclfrom
HPS-1 wants to merge 1 commit intointel:syclfrom
Conversation
…)" This reverts commit 5ec9fac.
Contributor
Author
|
@intel/dpcpp-sanitizers-review @intel/dpcpp-clang-driver-reviewers @intel/dpcpp-tools-reviewers @intel/llvm-reviewers-runtime Hi, could you please take a look & approve this PR (it's simply a reversion of a previous commit) so we can merge it? Thanks in advance! |
cperkinsintel
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5ec9fac.
Below is a bit about the background:
In commit 5ec9fac we updated the ID and semantics of the HostAccessINTEL decoration. This has caused some problems on older drivers including the LTS drivers since they don't recognize this new ID. Unfortunately, for the time being it's not quite feasible to adapt such changes on the drivers' side, so after some discussion we have decided to revert the aforementioned commit and stick with the old code for now.