Add program handle lock test#21857
Merged
Merged
Conversation
kweronsx
force-pushed
the
add-program-handle-mt-tests
branch
2 times, most recently
from
03615f5 to
76619d5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new SYCL thread-safety unit test to validate that program handles used for device_global (device-image-scope) enqueue operations are safely read/propagated across concurrent queue::copy calls during a build race.
Changes:
- Introduces a new
DeviceGlobalProgramHandle.cppunit test that forces a concurrent build (urProgramBuildExp) and validates all threads observe the same non-nullur_program_handle_tinurEnqueueDeviceGlobalVariableWrite. - Updates the
thread_safetyunit test CMake target to compile the new test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
sycl/unittests/thread_safety/DeviceGlobalProgramHandle.cpp |
New thread-safety test that blocks program build to create contention and captures UR program handles passed to device-global write enqueues. |
sycl/unittests/thread_safety/CMakeLists.txt |
Adds the new test source to the ThreadSafetyTests target. |
kweronsx
force-pushed
the
add-program-handle-mt-tests
branch
from
76619d5 to
6309bda
Compare
kweronsx
force-pushed
the
add-program-handle-mt-tests
branch
from
6309bda to
219e944
Compare
kweronsx
force-pushed
the
add-program-handle-mt-tests
branch
from
219e944 to
41be199
Compare
kweronsx
force-pushed
the
add-program-handle-mt-tests
branch
from
41be199 to
d5a7650
Compare
kweronsx
force-pushed
the
add-program-handle-mt-tests
branch
from
d5a7650 to
ad8113b
Compare
kweronsx
force-pushed
the
add-program-handle-mt-tests
branch
from
ad8113b to
b8e744c
Compare
cperkinsintel
approved these changes
Apr 28, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
|
@kweronsx new lines at the end are missing, could you please check |
kweronsx
force-pushed
the
add-program-handle-mt-tests
branch
from
b8e744c to
0678a3c
Compare
Contributor
Author
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MT tests for usage of Program handle: https://jira.devtools.intel.com/browse/URLZA-410