Added function to link libraries over Windows UNC network paths#22172
Open
travisle2 wants to merge 2 commits into
Open
Added function to link libraries over Windows UNC network paths#22172travisle2 wants to merge 2 commits into
travisle2 wants to merge 2 commits into
Conversation
Applied function to OpenCl Library
omirochn
reviewed
May 29, 2026
|
|
||
| # Check for OpenCL ICD | ||
| if config.opencl_libs_dir: | ||
| tmp_opencl_libs_dir = config.opencl_libs_dir |
There was a problem hiding this comment.
Suggested change
| tmp_opencl_libs_dir = config.opencl_libs_dir | |
| opencl_lib = config.opencl_libs_dir + "/OpenCL.lib" |
Comment on lines
+573
to
+581
| if is_windows_unc_network_path(tmp_opencl_libs_dir): | ||
| tmp_opencl_libs_dir = quote_path(normalize_windows_network_path(tmp_opencl_libs_dir) + "\\\\OpenCL.lib") | ||
| config.substitutions.append( | ||
| ("%opencl_lib", " " + tmp_opencl_libs_dir) | ||
| ) | ||
| else: | ||
| config.substitutions.append( | ||
| ("%opencl_lib", " " + config.opencl_libs_dir + "/OpenCL.lib") | ||
| ) |
There was a problem hiding this comment.
Suggested change
| if is_windows_unc_network_path(tmp_opencl_libs_dir): | |
| tmp_opencl_libs_dir = quote_path(normalize_windows_network_path(tmp_opencl_libs_dir) + "\\\\OpenCL.lib") | |
| config.substitutions.append( | |
| ("%opencl_lib", " " + tmp_opencl_libs_dir) | |
| ) | |
| else: | |
| config.substitutions.append( | |
| ("%opencl_lib", " " + config.opencl_libs_dir + "/OpenCL.lib") | |
| ) | |
| if is_windows_unc_network_path(opencl_lib): | |
| opencl_lib = normalize_windows_network_path(opencl_lib) | |
| config.substitutions.append( | |
| ("%opencl_lib", " " + quote_path(opencl_lib) | |
| ) |
Contributor
Author
|
Implemented suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enables the functionality for libraries to be linked from Windows UNC Network Paths. This is only applied to the OpenCL Library at the moment.