qat_init: fix check_driver() multi-module Live state comparison#150
Closed
aleksandrov-denis wants to merge 1 commit into
Closed
qat_init: fix check_driver() multi-module Live state comparison#150aleksandrov-denis wants to merge 1 commit into
aleksandrov-denis wants to merge 1 commit into
Conversation
When both qat_4xxx and qat_420xx modules are loaded (which happens on 420xx hardware even though qat_4xxx has no devices bound), get_module_state() returns two lines of output. The previous string equality check while [ "$CURRENT_STATE" != "Live" ] never matched because "Live\nLive" != "Live", causing the service to spin for the full 20-second timeout and exit with: QAT driver is still not present after 20s. Aborting qat_init Replace the equality check with a grep that succeeds as soon as any driver in the output reaches the Live state, which is the correct signal that the relevant hardware driver is ready to proceed. Signed-off-by: Denis Aleksandrov <daleksan@redhat.com>
Author
|
A better alternative was introduced in #151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both qat_4xxx and qat_420xx modules are loaded (which happens on 420xx hardware even though qat_4xxx has no devices bound), get_module_state()
returns two lines of output. The previous string equality check
while [ "$CURRENT_STATE" != "Live" ]
never matched because "Live\nLive" != "Live", causing the service to spin for the full 20-second timeout and exit with:
QAT driver is still not present after 20s. Aborting qat_init
Replace the equality check with a grep that succeeds as soon as any driver in the output reaches the Live state, which is the correct signal that the relevant hardware driver is ready to proceed.
This PR resolves #149