Skip to content

chore(deps): consolidate Python dependency upgrades (June 2026) - #13010

Open
mekarpeles wants to merge 5 commits into
masterfrom
deps/python-consolidation-2026-06-23
Open

chore(deps): consolidate Python dependency upgrades (June 2026)#13010
mekarpeles wants to merge 5 commits into
masterfrom
deps/python-consolidation-2026-06-23

Conversation

@mekarpeles

@mekarpeles mekarpeles commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary

Consolidates open Renovate PRs for Python packages into a single tested upgrade. All packages installed and tested in Docker before opening this PR.

Closes #12929.

Packages upgraded

Package Before After Severity File
beautifulsoup4 4.14.3 4.15.0 Low requirements.txt
sentry-sdk 2.61.1 2.62.0 Low requirements.txt
nameparser 1.1.3 1.2.0 Low requirements_scripts.txt
pytest 9.0.3 9.1.0 Low requirements_test.txt
ruff 0.15.16 0.15.17 Low requirements_test.txt

Excluded packages

Package Current Available Reason
luqum 0.11.0 0.14.0 Breaks test_luqum_parser — 0.14.x changed query parenthesization behaviour (by:(boo blah blah)by:boo blah blah). Needs a dedicated fix before bumping.
fastapi 0.136.3 0.137.1 Breaks FastAPI tests — 0.137.x introduced _IncludedRouter which lacks a .path attribute. prometheus_fastapi_instrumentator==7.1.0 calls route.path unconditionally and crashes on it. Needs a coordinated bump with prometheus-fastapi-instrumentator (7.1.0 → 8.x).

Testing

  • All 5 packages installed in Docker and verified at correct versions ✓
  • openlibrary/tests/solr/test_query_utils.py — 10/10 passed ✓
  • luqum 0.14.0 confirmed failing test_luqum_parser (excluded for this reason) ✓
  • fastapi 0.137.1 confirmed breaking FastAPI test suite via CI (_IncludedRouter + prometheus-fastapi-instrumentator incompatibility) ✓

Checklist

  • All packages install cleanly
  • App serves HTTP 200
  • Tests passing (query_utils)
  • CI passing (after fastapi exclusion)

@mekarpeles
mekarpeles force-pushed the deps/python-consolidation-2026-06-23 branch from 71c48d7 to 4242a5e Compare June 23, 2026 07:48
@mekarpeles

Copy link
Copy Markdown
Member Author

CI fix: excluded fastapi 0.136.3→0.137.1 (force-pushed)

The `python_tests` CI run failed because `fastapi==0.137.1` introduced `_IncludedRouter`, a new route type that lacks a `.path` attribute. `prometheus_fastapi_instrumentator==7.1.0` (currently pinned in `requirements.txt`) calls `route.path` unconditionally during request routing, which crashes on `_IncludedRouter` instances.

Root cause trace:
```
prometheus_fastapi_instrumentator/routing.py:55: route_name = route.path
AttributeError: '_IncludedRouter' object has no attribute 'path'
```

Fix: Removed the fastapi bump from this PR and added it to the Excluded table. A separate coordinated bump is needed: fastapi 0.137.x + prometheus-fastapi-instrumentator 7.1.0→8.x (which presumably adds hasattr guarding).

This was AI-assisted (Reno, via PAM). Force-push used `--force-with-lease`. To restore the previous state: `git reflog` locally to find the prior SHA, then `git reset --hard ` + `git push --force-with-lease`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant