[PB-6280]: create folders from DocumentsProvider createDocument#476
Open
terrerox wants to merge 3 commits into
Open
[PB-6280]: create folders from DocumentsProvider createDocument#476terrerox wants to merge 3 commits into
terrerox wants to merge 3 commits into
Conversation
terrerox
force-pushed
the
feature/PB-6281-upload-tests
branch
from
bfd599c to
b869027
Compare
Implement the folder branch of InternxtDocumentsProvider.createDocument so users can create folders from the Android system file picker (SAF "New folder"). When the requested mimeType is MIME_TYPE_DIR, the provider resolves a non-colliding name, POSTs via InternxtApiClient.createFolder, invalidates the parent's cached children, and returns the encoded folder document id. The existing pending-upload path is preserved for files. Extract the pure naming logic (uniqueName, splitNameExt, joinNameType) into a standalone DocumentNaming object and collapse the duplicated file/folder name resolvers into a single generic uniqueChildName helper, so the only difference between them is the list endpoint and name extractor. Add DocumentNaming unit tests covering collision suffixing, extension preservation, the bare-folder case, and the split/join edge cases.
terrerox
force-pushed
the
feature/PB-6280-create-folder
branch
from
5b6a97b to
b6a285e
Compare
|
xabg2
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the folder branch of InternxtDocumentsProvider.createDocument so users can create folders from the Android system file picker (SAF "New folder"). When the requested mimeType is MIME_TYPE_DIR, the provider resolves a non-colliding name, POSTs via InternxtApiClient.createFolder, invalidates the parent's cached children, and returns the encoded folder document id. The existing pending-upload path is preserved for files.
Extract the pure naming logic (uniqueName, splitNameExt, joinNameType) into a standalone DocumentNaming object and collapse the duplicated file/folder name resolvers into a single generic uniqueChildName helper, so the only difference between them is the list endpoint and name extractor.
Add DocumentNaming unit tests covering collision suffixing, extension preservation, the bare-folder case, and the split/join edge cases.