Skip to content

fix(): import method from colorette#34

Merged
jcesarmobile merged 1 commit into
ionic-team:mainfrom
rdlabo-team:fix/colorette
Jan 20, 2022
Merged

fix(): import method from colorette#34
jcesarmobile merged 1 commit into
ionic-team:mainfrom
rdlabo-team:fix/colorette

Conversation

@rdlabo

@rdlabo rdlabo commented Dec 25, 2021

Copy link
Copy Markdown
Contributor

fix cli error:

TypeError: Cannot read properties of undefined (reading 'red')
    at Object.run (/Users/sakakibara/dev/capacitor-docgen/dist/cli.js:59:47)

import c from 'colorette'; is undefined.

import { green, red } from 'colorette';

M1 Mac

System:
   NodeJS : v16.13.1
   npm    : 8.1.2
   OS     : macOS Monterey

@tobium

tobium commented Jan 18, 2022

Copy link
Copy Markdown

can we merge this fix please?

@rdlabo

rdlabo commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

@tobium The schedule for review and merge is up to the ionic-team. But you can use from GitHub repository:

@capacitor/docgen@git+https://github.com/rdlabo/capacitor-docgen.git#release

I built for use with stripe-plugin: https://github.com/capacitor-community/stripe/blob/master/package.json#L51
This branch has this pull-request and #35

@jcesarmobile jcesarmobile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@jcesarmobile jcesarmobile merged commit 831fb94 into ionic-team:main Jan 20, 2022
@rdlabo rdlabo deleted the fix/colorette branch January 29, 2022 06:57
jcesarmobile added a commit that referenced this pull request Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants