feat: Use functional API of @googlemaps/js-api-loader#148
Closed
AE1NS wants to merge 1 commit into
Closed
Conversation
AE1NS
force-pushed
the
api-loader-refactoring
branch
from
9759fd8 to
7dbd527
Compare
Contributor
|
We started on the basics of this as a result of #151 |
OS-pedrogustavobilro
approved these changes
Dec 12, 2025
markemer
approved these changes
Dec 12, 2025
AE1NS
force-pushed
the
api-loader-refactoring
branch
from
2859f13 to
59db00c
Compare
Contributor
|
I squashed and rebased everything and the only thing left up with my initial changes, is that I used the static import of the @googlemaps/js-api-loader module. If the current dynamic import implementation should be kept, this PR (and ticket) can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147