fix(header, content): update colors for ionic theme#30491
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
left a comment
There was a problem hiding this comment.
These changes don't seem to be necessary as it's working as expected. I would recommend providing a minimal JS environment that shows what the issue is so we can provide a different solution.
There was a problem hiding this comment.
Why are these changes needed? This is already being set through the modal ionic theme file.
The background is updating as expected when I change it locally:

There was a problem hiding this comment.
Why are these changes needed? This can already be done through styling:
ion-modal ion-header ion-toolbar {
--background: pink;
}We have documentation on best practices for style customization when it comes to modals. I would recommend reviewing that.
|
@joselrio is it safe to delete the branch? |


Issue number: resolves #
What is the current behavior?
What is the new behavior?
in-modalto header and content when used inside the modal.Does this introduce a breaking change?
Other information
https://ionic-framework-git-rou-11977-v2-ionic1.vercel.app/src/components/modal/test/basic?ionic:theme=ionic