Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
requested changes
Dec 8, 2025
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Small issue with the console warn message but other than that it looks good!
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
brandyscarney
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
high-contrastandhigh-contrast-darkpalettes were not working when requested through a URL query or hash for a test page. This was due to thematchnot accepting hyphens so it would only savehighwhich is not a valid palette.What is the new behavior?
matchto accept hyphensDoes this introduce a breaking change?
Other information
How to test:
?palette=high-contrast,?palette=high-contrast-dark,#palette=high-contrast, and#palette=high-contrast-darkrender correctly (I recommend using button basic page)