Skip to content

fix(segment-button): correct color for button childs#30891

Merged
JoaoFerreira-FrontEnd merged 2 commits into
nextfrom
ROU-12439
Dec 26, 2025
Merged

fix(segment-button): correct color for button childs#30891
JoaoFerreira-FrontEnd merged 2 commits into
nextfrom
ROU-12439

Conversation

@JoaoFerreira-FrontEnd

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Dec 26, 2025

Copy link
Copy Markdown
Contributor

Issue number: internal

What is the new behavior?

  • guarantee that every child of segment-button has color: primary-color when checked;

Does this introduce a breaking change?

  • Yes
  • No

Sample: https://ionic-framework-git-rou-12439-ionic1.vercel.app/src/components/segment/test/basic?ionic:theme=ionic

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner December 26, 2025 15:52
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd added the type: bug a confirmed bug report label Dec 26, 2025
@vercel

vercel Bot commented Dec 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
ionic-framework Ready Ready Preview, Comment Dec 26, 2025 5:34pm

@github-actions github-actions Bot added the package: core @ionic/core package label Dec 26, 2025
Comment thread core/src/components/segment-button/segment-button.ionic.scss Outdated
Comment thread core/src/components/segment-button/segment-button.ionic.scss Outdated
- add changes to disabled state;

@ShaneK ShaneK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 6c74618 into next Dec 26, 2025
49 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-12439 branch December 26, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package type: bug a confirmed bug report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants