feat(img): add recipe and tokens#31167
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| cp -r "${CORE_DIR}/src" "${OUTPUT_DIR}/src" | ||
| cp -r "${CORE_DIR}/dist" "${OUTPUT_DIR}/dist" | ||
| cp -r "${CORE_DIR}/css" "${OUTPUT_DIR}/css" | ||
| cp -r "${CORE_DIR}/themes" "${OUTPUT_DIR}/themes" |
There was a problem hiding this comment.
The themes/ directory (generated by npm run build.themes and dynamically imported by scripts.js at runtime as /themes/{theme}/default.tokens.js) wasn't being copied into the Vercel output, so the token modules 404'd in deployed previews while working fine locally where the dev server serves it from core/.
github-actions
Bot
added
package: core
| test.describe(title('img: basic'), () => { | ||
| // TODO FW-3596 | ||
| test.describe.skip('image successfully loads', () => { | ||
| test.describe('image successfully loads', () => { |
There was a problem hiding this comment.
This test was originally marked skip under FW-3596 because it was flaky on CI. That predates the move to Docker based e2e runs, where the test environment is now deterministic (pinned browser, pinned OS, controlled timing). The flake was almost certainly caused by host environment variance.
Verified stable by running npm run test.e2e.docker img/test/basic -- --repeat-each=80 locally several times. Zero failures.
If the test ends up flaking in the future, we can skip and create a new ticket to address it.
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks good to me! Great work 🎉
There was a problem hiding this comment.
The old version was accidentally added during a sync. The original version was generated through a flaky test so it's not the true snapshot.
4 participants
Issue number: resolves internal
What is the current behavior?
ion-imgreads the active theme viagetIonTheme()and applies it as a host class even though no SCSS rule depends on the theme class. The@virtualProp themeis also exposed publicly.What is the new behavior?
Does this introduce a breaking change?
This PR introduces breaking changes to how
ion-imgis styled.Migration Path:
ion-img.md,ion-img.ios.Other information
Previews