Skip to content

refactor(many): delete extra files and update vercel build#31169

Merged
thetaPC merged 1 commit into
ionic-modularfrom
merge-fixes
May 26, 2026
Merged

refactor(many): delete extra files and update vercel build#31169
thetaPC merged 1 commit into
ionic-modularfrom
merge-fixes

Conversation

@thetaPC

@thetaPC thetaPC commented May 26, 2026

Copy link
Copy Markdown
Contributor

Issue number: N/A


What is the current behavior?

  • Some files were not deleted during the last sync.
  • Tokens are no longer being loaded into the pages.

What is the new behavior?

  • Deleted files that are no longer being used within the Modular Ionic
  • Tokens are now being loaded into the pages

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@vercel

vercel Bot commented May 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment May 26, 2026 4:15pm

Request Review

cp -r "${CORE_DIR}/src" "${OUTPUT_DIR}/src"
cp -r "${CORE_DIR}/dist" "${OUTPUT_DIR}/dist"
cp -r "${CORE_DIR}/css" "${OUTPUT_DIR}/css"
cp -r "${CORE_DIR}/themes" "${OUTPUT_DIR}/themes"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The themes/ directory (generated by npm run build.themes and dynamically imported by scripts.js at runtime as /themes/{theme}/default.tokens.js) wasn't being copied into the Vercel output, so the token modules 404'd in deployed previews while working fine locally where the dev server serves it from core/.

@github-actions github-actions Bot added the package: core @ionic/core package label May 26, 2026
@thetaPC thetaPC marked this pull request as ready for review May 26, 2026 16:43
@thetaPC thetaPC requested a review from a team as a code owner May 26, 2026 16:43
@thetaPC thetaPC requested a review from gnbm May 26, 2026 16:43
@thetaPC thetaPC changed the title fix(many): delete extra files and update vercel build refactor(many): delete extra files and update vercel build May 26, 2026
@thetaPC thetaPC merged commit 99872df into ionic-modular May 26, 2026
50 checks passed

@ShaneK ShaneK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thetaPC thetaPC deleted the merge-fixes branch May 26, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants