Skip to content

feat(select): remove role from action sheet interface#31221

Merged
thetaPC merged 6 commits into
major-9.0from
FW-6982
Jun 17, 2026
Merged

feat(select): remove role from action sheet interface#31221
thetaPC merged 6 commits into
major-9.0from
FW-6982

Conversation

@thetaPC

@thetaPC thetaPC commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Issue number: resolves internal


What is the current behavior?

A role value is being passed within the action sheet interface when it's being opened through the ion-select. This does not match with how the other interfaces behave, which can be seen through event.detail.

What is the new behavior?

  • Removed the role from the action sheet interface within the ion-select

Does this introduce a breaking change?

  • Yes
  • No

When using interface="action-sheet", ion-select no longer assigns the selected role to the action sheet button for the currently selected option. This aligns the action-sheet interface with the alert, popover, and modal interfaces, none of which assign this role. The selected option's styling is unchanged because it is driven by the option's checked state.

Because the option button no longer carries the selected role, the action sheet's dismiss role for a selected option is no longer "selected". Apps that inspected this role to detect that a value was chosen, such as reading role from the underlying action sheet's onDidDismiss result, should listen for ion-select's ionChange event instead, which emits the selected value when the selection changes.

Other information

Preview

@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment Jun 16, 2026 11:03pm

Request Review

@github-actions github-actions Bot added the package: core @ionic/core package label Jun 16, 2026
@thetaPC thetaPC marked this pull request as ready for review June 16, 2026 17:03
@thetaPC thetaPC requested a review from a team as a code owner June 16, 2026 17:03
@thetaPC thetaPC requested review from OS-jacobbell and brandyscarney and removed request for OS-jacobbell June 16, 2026 17:03

@brandyscarney brandyscarney left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some non-blocking comments on the breaking changes.

Comment thread BREAKING.md
Comment thread BREAKING.md Outdated
Comment thread BREAKING.md Outdated
thetaPC and others added 2 commits June 16, 2026 14:23
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
@thetaPC thetaPC merged commit e6cf649 into major-9.0 Jun 17, 2026
50 checks passed
@thetaPC thetaPC deleted the FW-6982 branch June 17, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants