Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
approved these changes
Jun 16, 2026
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Looks good! Some non-blocking comments on the breaking changes.
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
A
rolevalue is being passed within the action sheet interface when it's being opened through theion-select. This does not match with how the other interfaces behave, which can be seen throughevent.detail.What is the new behavior?
rolefrom the action sheet interface within theion-selectDoes this introduce a breaking change?
When using
interface="action-sheet",ion-selectno longer assigns theselectedrole to the action sheet button for the currently selected option. This aligns theaction-sheetinterface with thealert,popover, andmodalinterfaces, none of which assign this role. The selected option's styling is unchanged because it is driven by the option's checked state.Because the option button no longer carries the
selectedrole, the action sheet's dismiss role for a selected option is no longer"selected". Apps that inspected this role to detect that a value was chosen, such as readingrolefrom the underlying action sheet'sonDidDismissresult, should listen forion-select'sionChangeevent instead, which emits the selected value when the selection changes.Other information
Preview