fix: iOS fade header color missmatch#31252
Open
Austin-Spriggs wants to merge 3 commits into
Open
Conversation
|
@Austin-Spriggs is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
Austin-Spriggs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30939
What is the current behavior?
When opening a modal that contains both a fade header and a content element with a color attribute, the fade header will appear without any background, showing a white/black gap that doesn't match the content color when at the top of the page.
What is the new behavior?
I added logic to recalculate the ion-content dimensions after the header has finished rendering. This ensures the content size is correct and fills the background gap behind the fade header.
Does this introduce a breaking change?
Other information